Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][ci] Add new CI unit test group "Broker Group 4" with cluster migration tests #21391

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[improve][ci] Add new CI unit test group "Broker Group 4" with cluster migration tests #21391

merged 1 commit into from
Oct 18, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 18, 2023

Motivation

There are too many tests in the "broker" TestNG test group which gets executed in the "Broker Group 1" CI job.
The tests could take over 60 minutes to run and that is currently the timeout.

Modifications

Add a new "Broker Group 4" unit test group and build job.
Move one of the slowest tests "ClusterMigrationTest" to "cluster-migration" TestNG test group. Assign "cluster-migration" to "Broker Group 4".

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 18, 2023
@lhotari
Copy link
Member Author

lhotari commented Oct 18, 2023 •
edited
Loading

@rdhabalia @vineeth1995 @vraulji567 Please review!

I'm moving ClusterMigrationTest since it seems to be one of the slowest tests.

Gradle Enterprise analytics from a few days ago:
https://ge.apache.org/s/ucnihfo5rnoyi/tests/slowest-tests
https://ge.apache.org/s/ucnihfo5rnoyi/tests/goal/org.apache.pulsar:pulsar-broker:surefire:test@default-test/details/org.apache.pulsar.broker.service.ClusterMigrationTest?top-execution=1

Links to Gradle Enterprise build scans can be found in the scheduled master branch builds:
https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml?query=branch%3Amaster

Scroll to the summary of the build job in the summary view
example:
image
online:
https://github.com/apache/pulsar/actions/runs/6533326173/attempts/1#summary-17738916032

@lhotari lhotari self-assigned this Oct 18, 2023
@lhotari lhotari added this to the 3.2.0 milestone Oct 18, 2023
@lhotari
Copy link
Member Author

lhotari commented Oct 18, 2023

/pulsarbot rerun-failure-checks

@mattisonchao
Copy link
Member

I am unsure if we should start a discussion or notification for the community. :)

@lhotari
Copy link
Member Author

lhotari commented Oct 18, 2023

I am unsure if we should start a discussion or notification for the community. :)

@mattisonchao I have sent a notification on the dev mailing list, it's https://lists.apache.org/thread/s7odd1kh5mwgvmcdf2ynkfbh68zbcomf .

tisonkun
tisonkun approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a try.

@lhotari lhotari merged commit e2c6c08 into apache:master Oct 18, 2023
57 of 58 checks passed
lhotari added a commit that referenced this pull request Oct 18, 2023
@lhotari
[improve][ci] Add new CI unit test group "Broker Group 4" with cluste…
9c467bb 
…r migration tests (#21391)

(cherry picked from commit e2c6c08)
lhotari added a commit that referenced this pull request Oct 18, 2023
@lhotari
[improve][ci] Add new CI unit test group "Broker Group 4" with cluste…
10affd2 
…r migration tests (#21391)

(cherry picked from commit e2c6c08)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
@lhotari @nikhil-ctds
[improve][ci] Add new CI unit test group "Broker Group 4" with cluste…
1bbfa8b 
…r migration tests (apache#21391)

(cherry picked from commit e2c6c08)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
@lhotari @srinath-ctds
[improve][ci] Add new CI unit test group "Broker Group 4" with cluste…
ca1ccd9 
…r migration tests (apache#21391)

(cherry picked from commit e2c6c08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@tisonkun tisonkun tisonkun approved these changes

@nodece nodece nodece approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@vineeth1995 vineeth1995 Awaiting requested review from vineeth1995

Assignees

@lhotari lhotari

Labels
area/ci cherry-picked/branch-3.0 cherry-picked/branch-3.1 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.2 release/3.1.2
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lhotari @mattisonchao @nodece @tisonkun